fix: assert time-left is formatted correctly#772
fix: assert time-left is formatted correctly#772tbushman merged 1 commit intofreeCodeCamp:masterfrom
Conversation
|
@abdusabri I was trying both the links you posted, and noticed the tests pass for both. Did you update the first link listed above? |
|
Thanks for checking @tbushman I didn't change either of the links https://abdusabri.github.io/fcc-pomodoro-bug/ -> uses the CDN version of the tests, and all tests pass https://abdusabri.github.io/fcc-pomodoro-fix/ -> uses a production build of this PR's tests, and one test fails (screenshots in this PR's description) Would it help if i send a few screenshots comparing them (showing the urls and more details)? |
|
@abdusabri Mainly I checked the first link, expecting it to fail. Sorry. I think we're probably good. Thanks for your patience. |
|
@tbushman No worries! 🙂 and thanks for reviewing! |
|
@abdusabri I noticed we're using a RegExp on line 83. I think it would be safest to emulate that style of assertion. |
fix: assert time-left is formatted correctly fix: assert time-left is formatted correctly, use getMinutes
abdusabri
force-pushed
the
fix/assert-time-left-format
branch
from
cd4184a to
7d0a548
Compare
|
@tbushman Thanks for the feedback I've updated the code to use |
|
Alrighty, @abdusabri ! Thanks for your contribution. Congratulations on your first contribution to this repository. LGTM! |
2 participants
Pre-Submission Checklist
masterbranch of freeCodeCamp/testable-projects-fccfix/,feature/, ortranslate/(e.g.fix/signin-issue)npm run buildType of Change
Checklist:
Description
This PR fixes an assertion issue for the pomodoro clock testing project. The issue was that all tests pass even if the
time-leftwas incorrectly formatted as00:00instead of60:00when session length is set to60The following screenshots demonstrate the fix
An example project before the fix can be found here: https://abdusabri.github.io/fcc-pomodoro-bug/
An example project after the fix can be found here: https://abdusabri.github.io/fcc-pomodoro-fix/