Skip to content

fix(curriculum): add missing tested requirements to travel agency lab - #68672

Merged
majestic-owl448 merged 3 commits into
freeCodeCamp:mainfrom
TemRevil:fix/travel-agency-lab-user-stories
Jul 13, 2026
Merged

majestic-owl448 merged 3 commits into
freeCodeCamp:mainfrom
TemRevil:fix/travel-agency-lab-user-stories

Conversation

@TemRevil

Copy link
Copy Markdown
Contributor

Checklist:

Closes #68669

The Build a Travel Agency Page lab enforces two behaviors in its hints that the user stories never state:

  • the hint You should only have one h1 element — but story 5 only asks for an h1
  • the hint Each figcaption should contain some text — but story 11 only asks that each figure contain a figcaption

This updates the two user stories so every tested behavior is stated, reusing the hint wording:

  • Story 5: "You should have an h1 element to present your travel destinations. It should be the only h1 element on your page."
  • Story 11: "You should have at least three figure elements, each containing an anchor element and a figcaption element. Each figcaption should contain some text."

English curriculum file only (curriculum/challenges/english/blocks/lab-travel-agency-page/669e2f60e83c011754f711f9.md); no hint/test logic changed, so the lab's behavior is identical — the instructions just stop under-specifying it.

@TemRevil
TemRevil requested review from a team as code owners July 10, 2026 09:36
@github-actions github-actions Bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Jul 10, 2026
@TemRevil

Copy link
Copy Markdown
Contributor Author

Good catch, thanks. That line was restating the same requirement the hint below it already covers, so I applied your suggestion to point forward instead of duplicating it. Pushed.

@TemRevil

Copy link
Copy Markdown
Contributor Author

@majestic-owl448 good call, thanks. That user story is deduped now so it reads the way you suggested (the figure, anchor, and figcaption wording is consolidated onto the one line in 99bfd61). Happy to tweak the phrasing further if you would word it differently.

…9e2f60e83c011754f711f9.md

Signed-off-by: majestic-owl448 <[email protected]>

@majestic-owl448 majestic-owl448 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TemRevil. Congrats on your first pull request (PR)! 🎉

Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 📝

@majestic-owl448
majestic-owl448 enabled auto-merge (squash) July 13, 2026 07:26
@majestic-owl448
majestic-owl448 merged commit 97e0519 into freeCodeCamp:main Jul 13, 2026
11 checks passed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User stories in Build a Travel Agency Page lab omit two tested requirements

2 participants