Skip to content
This repository was archived by the owner on Sep 25, 2019. It is now read-only.

fix(challenges): fixed telephone number validator project#53

Merged
scissorsneedfoodtoo merged 1 commit intofreeCodeCamp:devfrom
gforce2k5:fix/telephone-number-validator
Jun 27, 2018
Merged

fix(challenges): fixed telephone number validator project#53
scissorsneedfoodtoo merged 1 commit intofreeCodeCamp:devfrom
gforce2k5:fix/telephone-number-validator

Conversation

@gforce2k5
Copy link
Copy Markdown
Contributor

@gforce2k5 gforce2k5 commented Jun 25, 2018

fixed telephone number validator projects to show example telephone numbers on new lines

ISSUES CLOSED: #47

Pre-Submission Checklist

  • Your pull request targets the staging branch of freeCodeCamp.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Add new translation (feature adding new translations)

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #47

Description

@gforce2k5
fix(challenges): fixed telephone number validator project
780162e 
fixed telephone number validator projects to show example telephone numbers on new lines

ISSUES CLOSED: #47
@scissorsneedfoodtoo
Copy link
Copy Markdown
Contributor

scissorsneedfoodtoo commented Jun 27, 2018

@gforce2k5, thank you for submitting a PR to fix this issue. Your changes look good! But I noticed that your changes are from an unknown repository. Did you make your changes directly in the web editor? If so, I'm not sure if we can merge this. Unfortunately, you may have to close this and submit another PR. What do you think, @raisedadead?

@gforce2k5
Copy link
Copy Markdown
Contributor Author

gforce2k5 commented Jun 27, 2018

It happened because I deleted the repo from my user repo after submitting this PR

@raisedadead
Copy link
Copy Markdown
Member

raisedadead commented Jun 27, 2018

@scissorsneedfoodtoo if the changes are good, this maybe merged. If they need to make additional changes, they would have to close and make a fresh PR.

@scissorsneedfoodtoo
Copy link
Copy Markdown
Contributor

scissorsneedfoodtoo commented Jun 27, 2018

@raisedadead, thank you! I'll keep that in mind for future QAing.

@scissorsneedfoodtoo
Copy link
Copy Markdown
Contributor

scissorsneedfoodtoo commented Jun 27, 2018

✨ ✨ ✨ Awesome! Congratulations on your first contribution to freeCodeCamp! ✨ ✨ ✨

Thank you for submitting a PR for this issue, @gforce2k5. We're all really looking forward to your next contributions.

@scissorsneedfoodtoo scissorsneedfoodtoo merged commit e185b55 into freeCodeCamp:dev Jun 27, 2018
raisedadead pushed a commit that referenced this pull request Jun 29, 2018
@gforce2k5 @raisedadead
fix(challenges): fixed telephone number validator project (#53)
9d072c3 
fixed telephone number validator projects to show example telephone numbers on new lines

ISSUES CLOSED: #47
raisedadead pushed a commit that referenced this pull request Jun 29, 2018
@gforce2k5 @raisedadead
fix(challenges): fixed telephone number validator project (#53)
2b034e2 
fixed telephone number validator projects to show example telephone numbers on new lines

ISSUES CLOSED: #47
raisedadead pushed a commit that referenced this pull request Jun 29, 2018
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
ebf0399 
# [3.0.0](v2.0.0...v3.0.0) (2018-06-29)

### Bug Fixes

* **challenge:** Fixed the typo for automatically ([#48](#48)) ([dd046d6](dd046d6))
* **challenge:** Updated tests to avoid confusion ([#57](#57)) ([7105507](7105507))
* **challenges:** change test for template literals challenge ([#37](#37)) ([4b1c5eb](4b1c5eb))
* **challenges:** cherry pick pr 17664 & 17672 from main repo ([#52](#52)) ([2375d0c](2375d0c))
* **challenges:** fixed telephone number validator project ([#53](#53)) ([2b034e2](2b034e2)), closes [#47](#47)
* **challenges:** fixed typo in css-grid.json ([#46](#46)) ([e74192e](e74192e))
* **challenges:** grammar fix in css-grid auto-fit challenge ([#60](#60)) ([a6a0266](a6a0266))
* **challenges:** Typo errors ([#39](#39)) ([0c0702d](0c0702d))
* **challenges:** update regular expression that fails ([#56](#56)) ([9fa5907](9fa5907)), closes [#55](#55)

### BREAKING CHANGES

* **challenges:** None
raisedadead pushed a commit that referenced this pull request Jun 29, 2018
@semantic-release-bot @raisedadead
chore(release): 3.0.0 [skip ci]
9744d9f 
# [3.0.0](v2.0.0...v3.0.0) (2018-06-29)

### Bug Fixes

* **challenge:** Fixed the typo for automatically ([#48](#48)) ([dd046d6](dd046d6))
* **challenge:** Updated tests to avoid confusion ([#57](#57)) ([7105507](7105507))
* **challenges:** change test for template literals challenge ([#37](#37)) ([4b1c5eb](4b1c5eb))
* **challenges:** cherry pick pr 17664 & 17672 from main repo ([#52](#52)) ([2375d0c](2375d0c))
* **challenges:** fixed telephone number validator project ([#53](#53)) ([2b034e2](2b034e2)), closes [#47](#47)
* **challenges:** fixed typo in css-grid.json ([#46](#46)) ([e74192e](e74192e))
* **challenges:** grammar fix in css-grid auto-fit challenge ([#60](#60)) ([a6a0266](a6a0266))
* **challenges:** Typo errors ([#39](#39)) ([0c0702d](0c0702d))
* **challenges:** update regular expression that fails ([#56](#56)) ([9fa5907](9fa5907)), closes [#55](#55)

### BREAKING CHANGES

* **challenges:** None
anku255 pushed a commit to anku255/curriculum that referenced this pull request Jun 30, 2018
@semantic-release-bot @anku255
chore(release): 3.0.0 [skip ci]
1f35ac3 
# [3.0.0](freeCodeCamp/curriculum@v2.0.0...v3.0.0) (2018-06-29)

### Bug Fixes

* **challenge:** Fixed the typo for automatically ([freeCodeCamp#48](freeCodeCamp#48)) ([dd046d6](freeCodeCamp@dd046d6))
* **challenge:** Updated tests to avoid confusion ([freeCodeCamp#57](freeCodeCamp#57)) ([7105507](freeCodeCamp@7105507))
* **challenges:** change test for template literals challenge ([freeCodeCamp#37](freeCodeCamp#37)) ([4b1c5eb](freeCodeCamp@4b1c5eb))
* **challenges:** cherry pick pr 17664 & 17672 from main repo ([freeCodeCamp#52](freeCodeCamp#52)) ([2375d0c](freeCodeCamp@2375d0c))
* **challenges:** fixed telephone number validator project ([freeCodeCamp#53](freeCodeCamp#53)) ([2b034e2](freeCodeCamp@2b034e2)), closes [freeCodeCamp#47](freeCodeCamp#47)
* **challenges:** fixed typo in css-grid.json ([freeCodeCamp#46](freeCodeCamp#46)) ([e74192e](freeCodeCamp@e74192e))
* **challenges:** grammar fix in css-grid auto-fit challenge ([freeCodeCamp#60](freeCodeCamp#60)) ([a6a0266](freeCodeCamp@a6a0266))
* **challenges:** Typo errors ([freeCodeCamp#39](freeCodeCamp#39)) ([0c0702d](freeCodeCamp@0c0702d))
* **challenges:** update regular expression that fails ([freeCodeCamp#56](freeCodeCamp#56)) ([9fa5907](freeCodeCamp@9fa5907)), closes [freeCodeCamp#55](freeCodeCamp#55)

### BREAKING CHANGES

* **challenges:** None
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Telephone Number Validator - Examples are not presented on separate lines as expected

3 participants

@gforce2k5 @scissorsneedfoodtoo @raisedadead