fix(challenges): fix challenge for fallback value of CSS variable#121
fix(challenges): fix challenge for fallback value of CSS variable#121scissorsneedfoodtoo merged 1 commit intofreeCodeCamp:devfrom mpmaan:fix/fallback-color-penguin
Conversation
|
@mpmaan, thank you for taking the time to fix this issue. Going to ask for some help from @moT01 since he helped create these challenges. I have a few questions. About the penguin class, here's how it stands now: First, I'm guessing that penguin should be misspelled here to trigger the fallback classes bellow, so the class should read: Is that right? Then the penguin image in the preview is rendered like so: If so, then the default editor seed for penguin-top and penguin bottom should be: Then the user just needs to change the CSS variables to |
|
@scissorsneedfoodtoo my intention was to do the opposite (sort of) of what you are saying - you put the typo in the variable declaration, I originally put the typo in where the variable was used (.penguin-top/.penguin-bottom) - the way it stands on the live site is how it was intended (with the typo where the variables were used)... either way would work |
|
@moT01 The second way proposed by @scissorsneedfoodtoo will also change the color of beak and the feet because of the typo |
|
@moT01, I'm sorry, I misunderstood. I think I get it now. So everything up on the live site for the However, in Is that right? |
|
@scissorsneedfoodtoo yes, the preview is correct - and no, they werent accidentally corrected later |
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |


Description
The variable name needs to be incorrect so that the fallback value is used.
Pre-Submission Checklist
devbranch.fix/,feature/, ortranslate/(e.g.fix/challenge-tests)npm test.npm run committo generate a conventional commit message.Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
If they were done on the web interface you have ensured that you are creating conventional commit messages.
Checklist:
Closes freeCodeCamp/#17840,
Closes freeCodeCamp/#17699,