move to central ReferenceCountHolder class#1
Draft
yawkat wants to merge 7 commits into
Draft
Conversation
Motivation: Unsafe unavailability prevent some basic JIT optimizations while accessing buffers and reference counters, causing some pretty severe performance regression Modifications: Expose a VarHandle's 9 stub to enable Ja +9 to use it, if Unsafe is unavailable Result: Fixes netty#15485
franz1981
reviewed
Jul 16, 2025
| ); | ||
| private static final AtomicIntegerFieldUpdater<ReferenceCountHolder> UPDATER = config.updater(); // todo: fixed initializer for NI | ||
| private static final long OFFSET = config.fieldOffset(); // todo: recompute offset for NI | ||
| private static final ReferenceCountUpdater.Configuration.UpdaterType TYPE = config.updaterType(); |
Owner
There was a problem hiding this comment.
this won't work well sadly for hotspot; it would be better to use an int or anything different.
enums need to check for ordinals and other untrusty fields on the switch, instead of turning it into a constant
Author
There was a problem hiding this comment.
Yep I thought so, I think we need to get rid of the config class anyway
franz1981
force-pushed
the
4.2_varhandle
branch
6 times, most recently
from
d90e4df to
4d527be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Explain here the context, and why you're making that change.
What is the problem you're trying to solve.
Modification:
Describe the modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.