Merged
Conversation
elad-eyal
approved these changes
May 8, 2021
Collaborator
elad-eyal
left a comment
There was a problem hiding this comment.
The main change seems to be enabling upgrade of omniauth to v2.0.0 . However we are blocked on v1 beacuse of the LDAP gem so we will should not expirience anything out of the ordinary yet.
Omniauth v2 needs to change some links to use POST (to counter XSRF). I think we've done that already a while ago
Bumps [devise](https://github.com/plataformatec/devise) from 4.7.3 to 4.8.0. - [Release notes](https://github.com/plataformatec/devise/releases) - [Changelog](https://github.com/heartcombo/devise/blob/master/CHANGELOG.md) - [Commits](heartcombo/devise@v4.7.3...v4.8.0) Signed-off-by: dependabot[bot] <[email protected]>
1dd657d to
fb68f5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps devise from 4.7.3 to 4.8.0.
Changelog
Sourced from devise's changelog.
Commits
57d1a1dRelease v4.8.05d5636fMerge pull request #5369 from heartcombo/ca-lockable-reset-attemptsa3ae35eCreate a model hook around the lockable warden hook to reset attemptse8e0c27Revert "Lock bundler to 2.2.9 instead of latest"429afcbBundle updateef9a2f4Use minitest helpers to check if objects respond to certain methods0cd72a5Merge pull request #5347 from heartcombo/ca-build1ba53dcLock bundler to 2.2.9 instead of latestfaef12cUse the 6-0-stable version of Rails to fix issue with JSON responsesc82a381Bundle updateDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually