Skip to content

Bump devise from 4.7.3 to 4.8.0#822

Merged
manno merged 1 commit intomasterfrom
dependabot/bundler/devise-4.8.0
Jul 18, 2021
Merged

Bump devise from 4.7.3 to 4.8.0#822
manno merged 1 commit intomasterfrom
dependabot/bundler/devise-4.8.0

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 4, 2021

Bumps devise from 4.7.3 to 4.8.0.

Changelog

Sourced from devise's changelog.

4.8.0 - 2021-04-29

  • enhancements

    • Devise now enables the upgrade of OmniAuth 2+. Previously Devise would raise an error if you'd try to upgrade. Please note that OmniAuth 2 is considered a security upgrade and recommended to everyone. You can read more about the details (and possible necessary changes to your app as part of the upgrade) in their release notes. Devise's OmniAuth Overview wiki was also updated to cover OmniAuth 2.0 requirements.
      • Note that the upgrade required Devise shared links that initiate the OmniAuth flow to be changed to method: :post, which is now a requirement for OmniAuth, part of the security improvement. If you have copied and customized the Devise shared links partial to your app, or if you have other links in your app that initiate the OmniAuth flow, they will have to be updated to use method: :post, or changed to use buttons (e.g. button_to) to work with OmniAuth 2. (if you're using links with method: :post, make sure your app has rails-ujs or jquery-ujs included in order for these links to work properly.)
      • As part of the OmniAuth 2.0 upgrade you might also need to add the omniauth-rails_csrf_protection gem to your app if you don't have it already. (and you don't want to roll your own code to verify requests.) Check the OmniAuth v2 release notes for more info.
    • Introduce Lockable#reset_failed_attempts! model method to reset failed attempts counter to 0 after the user signs in.
      • This logic existed inside the lockable warden hook and is triggered automatically after the user signs in. The new model method is an extraction to allow you to override it in the application to implement things like switching to a write database if you're using the new multi-DB infrastructure from Rails for example, similar to how it's already possible with Trackable#update_tracked_fields!.
    • Add support for Ruby 3.
    • Add support for Rails 6.1.
    • Move CI to GitHub Actions.
  • deprecations

    • Devise::Models::Authenticatable::BLACKLIST_FOR_SERIALIZATION is deprecated in favor of Devise::Models::Authenticatable::UNSAFE_ATTRIBUTES_FOR_SERIALIZATION (@​hanachin)
Commits
  • 57d1a1d Release v4.8.0
  • 5d5636f Merge pull request #5369 from heartcombo/ca-lockable-reset-attempts
  • a3ae35e Create a model hook around the lockable warden hook to reset attempts
  • e8e0c27 Revert "Lock bundler to 2.2.9 instead of latest"
  • 429afcb Bundle update
  • ef9a2f4 Use minitest helpers to check if objects respond to certain methods
  • 0cd72a5 Merge pull request #5347 from heartcombo/ca-build
  • 1ba53dc Lock bundler to 2.2.9 instead of latest
  • faef12c Use the 6-0-stable version of Rails to fix issue with JSON responses
  • c82a381 Bundle update
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 4, 2021
Copy link
Collaborator

@elad-eyal elad-eyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main change seems to be enabling upgrade of omniauth to v2.0.0 . However we are blocked on v1 beacuse of the LDAP gem so we will should not expirience anything out of the ordinary yet.

Omniauth v2 needs to change some links to use POST (to counter XSRF). I think we've done that already a while ago

@dependabot dependabot bot force-pushed the dependabot/bundler/devise-4.8.0 branch from 1dd657d to fb68f5c Compare June 1, 2021 08:43
@manno manno merged commit e8cc237 into master Jul 18, 2021
@manno manno deleted the dependabot/bundler/devise-4.8.0 branch July 18, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants