Skip to content

bump rails and mimemagic#801

Merged
elad-eyal merged 1 commit intofrab:masterfrom
elad-eyal:bump_rails
Apr 16, 2021
Merged

bump rails and mimemagic#801
elad-eyal merged 1 commit intofrab:masterfrom
elad-eyal:bump_rails

Conversation

@elad-eyal
Copy link
Collaborator

mimemagic version 0.3.5 was yanked, and rails was upgraded to stop using mimemagic altogether. We still need mimemagic for kt-paperclip though (See kreeti/kt-paperclip#54) but at least it builds now.

@elad-eyal elad-eyal requested a review from saerdnaer April 2, 2021 13:21
@elad-eyal
Copy link
Collaborator Author

I think this may cause some files to not be offline identified when uploaded to frab. This will be eventually fixed by marcel.

Copy link
Contributor

@saerdnaer saerdnaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elad-eyal elad-eyal merged commit 6dcc195 into frab:master Apr 16, 2021
@elad-eyal elad-eyal deleted the bump_rails branch April 16, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants