Skip to content

[Security] Bump activerecord-session_store from 1.1.3 to 2.0.0#799

Merged
manno merged 2 commits intomasterfrom
dependabot/bundler/activerecord-session_store-2.0.0
Jul 18, 2021
Merged

[Security] Bump activerecord-session_store from 1.1.3 to 2.0.0#799
manno merged 2 commits intomasterfrom
dependabot/bundler/activerecord-session_store-2.0.0

Conversation

@dependabot-preview
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Mar 10, 2021

⚠️ Dependabot Preview has been deactivated ⚠️

This pull request was created by Dependabot Preview, and you've upgraded to Dependabot. This means it won't respond to dependabot commands nor will it be automatically closed if a new version is found.

If you close this pull request, Dependabot will re-create it the next time it checks for updates and everything will work as expected.


Bumps activerecord-session_store from 1.1.3 to 2.0.0. This update includes security fixes.

Vulnerabilities fixed

Sourced from The Ruby Advisory Database.

activerecord-session_store Timing Attack The activerecord-session_store (aka Active Record Session Store) component through 1.1.3 for Ruby on Rails does not use a constant-time approach when delivering information about whether a guessed session ID is valid. Consequently, remote attackers can leverage timing discrepancies to achieve a correct guess in a relatively short amount of time. This is a related issue to CVE-2019-16782.

Recommendation

Users should upgrade to activerecord-session_store version 2.0.0 or later.

Patched versions: >= 2.0.0 Unaffected versions: none

Sourced from The GitHub Security Advisory Database.

Activerecord-session_store Timing Attack The activerecord-session_store (aka Active Record Session Store) component through 1.1.3 for Ruby on Rails does not use a constant-time approach when delivering information about whether a guessed session ID is valid. Consequently, remote attackers can leverage timing discrepancies to achieve a correct guess in a relatively short amount of time. This is a related issue to CVE-2019-16782.

Recommendation

As of the publishing of this advisory there is no official fix in place. An unnoficial fix is described in this comment.

Affected versions: <= 1.1.3

Release notes

Sourced from activerecord-session_store's releases.

Version 2.0.0

  • Drop support to Rails < 5.2 and Ruby < 2.2 (5db9171)
  • Fix compatibility issue with ruby-head (#159)
  • Fix CVE-2015-9284 vulnerability (#151)
  • Add db:sessions:upgrade rake task to upgrade all existing sessions to the secure version (c23358c)

Please see CVE-2015-9284 mitigation section in the README file for more information about security vulnerability and mitigation.

Commits
  • 78e0047 Bump to 2.0.0
  • c23358c Move secure migration into a rake task
  • 1973f37 Update styling in README.md
  • b1f36fb Update build matrix
  • c16ddd2 Merge pull request #175 from thorsteneckel/patch-1
  • 4b705d9 Migration can not rolled back as sessions are now secure hashes. Thanks to @n...
  • 90a4cb2 Applied suggestions by @kratob
  • 59755d3 Added documentation on how to mitigate CVE-2015-9284.
  • 9d4dd11 Merge pull request #151 from rails-lts/secure-session-store
  • 532a9a5 Merge remote-tracking branch 'upstream/master' into secure-session-store
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability labels Mar 10, 2021
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/activerecord-session_store-2.0.0 branch from 3b33e76 to a7036d4 Compare April 16, 2021 14:04
@saerdnaer saerdnaer requested a review from elad-eyal May 4, 2021 20:10
@elad-eyal
Copy link
Collaborator

@saerdnaer @manno

The change seems to be benign at least.

However they also recommend to run rake db:sessions:upgrade to mitigate CVE-2019-25025 .

We can think about adding that to the dockerfile entrypoint script and/or to bin/rails

But I don't really know enough if this affects frab installations - i.e. does frab use whatever "sessions" are .

@manno manno merged commit e337676 into master Jul 18, 2021
@manno manno deleted the dependabot/bundler/activerecord-session_store-2.0.0 branch July 18, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants