Skip to content

Hotfixes for prod#756

Merged
manno merged 10 commits intomasterfrom
hotfixes-for-prod
Dec 15, 2020
Merged

Hotfixes for prod#756
manno merged 10 commits intomasterfrom
hotfixes-for-prod

Conversation

@manno
Copy link
Member

@manno manno commented Dec 5, 2020

No description provided.

@manno manno force-pushed the hotfixes-for-prod branch from 71d9c44 to fcd7ecb Compare December 5, 2020 16:17
manno added 2 commits December 5, 2020 18:07
Ideally frab would have switched to activestorage.
This should get rid of warnings for now.

#434
@manno manno force-pushed the hotfixes-for-prod branch from 73d7633 to fb751d6 Compare December 5, 2020 17:07
@elad-eyal
Copy link
Collaborator

elad-eyal commented Dec 5, 2020

Env vars must be lowercase true in order to be admitted? Also some documentation would be nice.

@manno manno force-pushed the hotfixes-for-prod branch 3 times, most recently from 48ef041 to c1c7c60 Compare December 5, 2020 19:38
@manno
Copy link
Member Author

manno commented Dec 5, 2020

I added some docs to the env.example file. I'm just doing this to get rid of a (too) complicated deployment branch.

I'm not too happy with the optional gem group support in Rails.

@manno manno force-pushed the hotfixes-for-prod branch from 133e3d5 to d7622b5 Compare December 5, 2020 20:00
@manno manno merged commit bb38f21 into master Dec 15, 2020
@manno manno deleted the hotfixes-for-prod branch December 15, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants