Skip to content

Longer allowed_event_timeslots_csv db field (v2)#726

Merged
elad-eyal merged 3 commits intofrab:masterfrom
elad-eyal:fix-mysql-allowed_event_timeslots_csv-column-v2
Oct 8, 2020
Merged

Longer allowed_event_timeslots_csv db field (v2)#726
elad-eyal merged 3 commits intofrab:masterfrom
elad-eyal:fix-mysql-allowed_event_timeslots_csv-column-v2

Conversation

@elad-eyal
Copy link
Collaborator

No description provided.

@elad-eyal elad-eyal force-pushed the fix-mysql-allowed_event_timeslots_csv-column-v2 branch 2 times, most recently from 4d6824f to 48e99bc Compare September 18, 2020 12:56
@elad-eyal elad-eyal changed the title WIP: Longer allowed_event_timeslots_csv db field (v2) Longer allowed_event_timeslots_csv db field (v2) Sep 19, 2020
@elad-eyal
Copy link
Collaborator Author

elad-eyal commented Sep 19, 2020

The maximum for this field is 1,2,...,100 which is 291 characters. Replacing :string to :text means max number of characters (in MySQL) will be 4K instead of 255.

This is my take on #724 , @manno ;

@elad-eyal elad-eyal force-pushed the fix-mysql-allowed_event_timeslots_csv-column-v2 branch 2 times, most recently from 0ea4f9a to e43fd62 Compare September 19, 2020 17:21
also fixes mysql migration error
@elad-eyal elad-eyal force-pushed the fix-mysql-allowed_event_timeslots_csv-column-v2 branch from e43fd62 to ab20490 Compare September 19, 2020 17:35
@elad-eyal
Copy link
Collaborator Author

elad-eyal commented Sep 19, 2020

Thanks to https://www.db4free.net I was able to validate this on mysql too

Copy link
Contributor

@saerdnaer saerdnaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elad-eyal elad-eyal merged commit 8920d13 into frab:master Oct 8, 2020
@elad-eyal elad-eyal deleted the fix-mysql-allowed_event_timeslots_csv-column-v2 branch October 9, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants