Merged
Conversation
elad-eyal
force-pushed
the
fix_blank_filter
branch
2 times, most recently
from
34067b4 to
2761839
Compare
Collaborator
Author
|
@erdgeist would you like to review this? |
Collaborator
Author
|
@manno would you like to review this? |
Collaborator
Author
Collaborator
Author
elad-eyal
force-pushed
the
fix_blank_filter
branch
from
2761839 to
03f7c80
Compare
elad-eyal
force-pushed
the
fix_blank_filter
branch
from
03f7c80 to
40f37c5
Compare
saerdnaer
approved these changes
Oct 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug from #579.
To reproduce the bug: Create two events. 1 with track field empty and 1 with track field populated. Open All Events. Click the filter item next to Track. Check V next to "(blank)", hit OK. It will not filter correctly.
So this fixes it.