fix test 'set ticket server to RT'#691
Merged
erdgeist merged 1 commit intofrab:masterfrom Feb 15, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this fix, the test "set ticket server to RT" started with clicking
Show->Settingsto edit a conference's settings, but there was no guarantee that the conference being edited is indeed@conference. So it seems to succeed most times but failed occasionally.This PR changes this so that the correct conference is being edited.
In order to facilitate that, I changed the conference factory so that conferences are now called
FrabCon2000,FrabCon2001etc. (instead ofFrabConandFrabCon sub); I had to change 1 other test accordingly.