hotfix: Unbreak Dockerfile: Explicitly set ruby to 2.6.5#687
Closed
elad-eyal wants to merge 1 commit intofrab:masterfrom
Closed
hotfix: Unbreak Dockerfile: Explicitly set ruby to 2.6.5#687elad-eyal wants to merge 1 commit intofrab:masterfrom
elad-eyal wants to merge 1 commit intofrab:masterfrom
Conversation
elad-eyal
changed the title
elad-eyal
changed the title
Collaborator
Author
|
#690 was merged so this is no longer needed. closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
(1) Changes
Dockerfileto useruby:2.6.5instead ofruby:latest(which is today 2.7 and does not work)(2) Adds ruby 2.6.5 to the CI to help finding out if the docker version breaks.
See #688
It's probably better to merge #690 instead of this PR.