Merged
Conversation
Configurable via environment variable FRAB_SHOW_ACTION_BAR_IN_CFP
elad-eyal
force-pushed
the
hide_action_bar
branch
from
bb56235 to
9b465bb
Compare
elad-eyal
changed the title
elad-eyal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to hide the "action bar" in the CfP screen - the group of buttons at the top of the cfp screen. I'm told that the current behavior, where each buttons appears twice (once green and once blue, for example) is confusing. The "action bar" in other views is not affected.
The default is maintaining legacy behavior. One can enable the new behavior by setting the environment variable
FRAB_SHOW_ACTION_BAR_IN_CFP=0Default behavior :
FRAB_SHOW_ACTION_BAR_IN_CFP=1FRAB_SHOW_ACTION_BAR_IN_CFP=0