Improve tests for review_metrics#675
Merged
erdgeist merged 3 commits intofrab:masterfrom Feb 15, 2020
Merged
Conversation
Merged
elad-eyal
force-pushed
the
improve_tests
branch
10 times, most recently
from
7df7192 to
d33f1f8
Compare
elad-eyal
force-pushed
the
improve_tests
branch
2 times, most recently
from
1cae515 to
df7ebb9
Compare
elad-eyal
force-pushed
the
improve_tests
branch
from
df7ebb9 to
59ed262
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit in this PR "add ransackers explicitly" makes sure any change to a review metric triggers a change in its
ransackerinevents.rb. The ransacker is used when sorting the events tables by a review metric. Without this change,rails frab:add_fake_datacreates non-sortable review metrics which was fixed by relaunching rails. Also some of the tests in this PR would have failed.The second commit in this PR "reorg tests for review_metric" changes the conference factory to support conference with review metrics and review scores.
test/features/editing_event_review_test.rbis changed to use this factoryThe third commit adds
test/features/sorting_event_list_test.rb, which iterates through all the sub-tabs in the Events page (ie., All Events, My Events, Attachments, Event Ratings, Feedbacks) and iterates through all the filter links, and makes sure they can sort ascending and descending.