Merged
Conversation
elad-eyal
force-pushed
the
filter_people_ajax
branch
from
ccad7c8 to
ee452c4
Compare
elad-eyal
force-pushed
the
filter_people_ajax
branch
from
ee452c4 to
f45796f
Compare
Merged
elad-eyal
force-pushed
the
filter_people_ajax
branch
from
f45796f to
4ff9275
Compare
elad-eyal
force-pushed
the
filter_people_ajax
branch
from
7c5a134 to
233b991
Compare
Collaborator
Author
|
Added test |
elad-eyal
force-pushed
the
filter_people_ajax
branch
3 times, most recently
from
242f951 to
ab622ab
Compare
elad-eyal
force-pushed
the
filter_people_ajax
branch
from
6c62b38 to
58f60d1
Compare
Collaborator
Author
|
Thank you @saerdnaer . I will merge this in 7 days if I don't get any feedback to the contrary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following a comment from @erdgeist I tried to rewrite the person-filter so that it is server-based and thus more responsive in deployments with large number of people in the database.
Up to 99 names are sent to the web client at a time, in which case they are listed in the dropbox selection box:
If there are too many matches, a message is displayed encouraging the user to keep typing
Once the text typed is specific enough to indicate an individual, the dropbox is replaced with a text box. There's no need to press ENTER to accept it.
Typing a person ID in the filter box works too - but it assumes the ID is complete. (So typing 5 will not match id 51 or 52)