replace omniauth-ldap with gitlab_omniauth-ldap #663
Merged
erdgeist merged 3 commits intofrab:masterfrom Feb 15, 2020
Merged
Conversation
allow LDAP to skip testing of server certificate
elad-eyal
force-pushed
the
update_omniauth_ldap
branch
from
d5101fb to
95d2c60
Compare
Collaborator
Author
|
I had to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #659
This PR:
(1) Adds a bunch of tests for LDAP login, using the free testing server at ldap.forumsys.com.
(2) replaces
omniauth-ldapgem withgitlab_omniauth-ldapgem, which allows upgrading upgradingomniauthfrom 1.8.1 to 1.9.0(3) Adds support for
LDAP_DISABLE_VERIFY_CERTification; Apparentlyomniauth-ldapdid not verify server certificate by default, andgitlab_omniauth-ldapdoes verify it by default.