Merged
Conversation
67a715f to
92a3fc6
Compare
9a1f0cf to
d57aab5
Compare
d57aab5 to
b196fa7
Compare
mysql default setup is not unicode
b196fa7 to
de503f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
adds to the CI
db:rollbackanddb:migratefor the last few migrations. So this validates that migrations can apply and can revert on all supported databases.On
sqliteonly, it verifies the resulting schema is the same as the original. This validates that new migrations are compatible with the updateddb/schema.rb.It removes a usage of unicode characters in one test, because it failed on
mysqlin some scenario. The same fix is also in Improve tests for review_metrics #675 .