Skip to content

CI test for migrations#662

Merged
erdgeist merged 3 commits intofrab:masterfrom
elad-eyal:test_for_migrations
Feb 15, 2020
Merged

CI test for migrations#662
erdgeist merged 3 commits intofrab:masterfrom
elad-eyal:test_for_migrations

Conversation

@elad-eyal
Copy link
Collaborator

@elad-eyal elad-eyal commented Nov 21, 2019

This PR:

  1. adds to the CI db:rollback and db:migrate for the last few migrations. So this validates that migrations can apply and can revert on all supported databases.

  2. On sqlite only, it verifies the resulting schema is the same as the original. This validates that new migrations are compatible with the updated db/schema.rb.

  3. It removes a usage of unicode characters in one test, because it failed on mysql in some scenario. The same fix is also in Improve tests for review_metrics #675 .

@elad-eyal elad-eyal closed this Nov 21, 2019
@elad-eyal elad-eyal reopened this Nov 21, 2019
@elad-eyal elad-eyal closed this Nov 21, 2019
@elad-eyal elad-eyal reopened this Nov 21, 2019
@elad-eyal elad-eyal force-pushed the test_for_migrations branch 2 times, most recently from 9a1f0cf to d57aab5 Compare November 21, 2019 16:14
@elad-eyal elad-eyal closed this Nov 21, 2019
@elad-eyal elad-eyal reopened this Nov 21, 2019
@elad-eyal elad-eyal changed the title WIP - Test for migrations CI test for migrations Nov 22, 2019
@erdgeist erdgeist merged commit a651894 into frab:master Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants