Limit set of allowed event durations in CfP#651
Merged
manno merged 4 commits intofrab:masterfrom Jul 12, 2020
Merged
Conversation
elad-eyal
force-pushed
the
config_allowed_durations
branch
3 times, most recently
from
72e2f8e to
a7fd75a
Compare
elad-eyal
changed the title
elad-eyal
force-pushed
the
config_allowed_durations
branch
from
a7fd75a to
807a88f
Compare
elad-eyal
force-pushed
the
config_allowed_durations
branch
3 times, most recently
from
6f20831 to
aaddab6
Compare
elad-eyal
force-pushed
the
config_allowed_durations
branch
from
aaddab6 to
0d5da4b
Compare
We always show duration in minutes.
elad-eyal
force-pushed
the
config_allowed_durations
branch
from
addf6bc to
944b1d4
Compare
Contributor
|
This would make lots of stuff easier. Is there more work required or could this be merged? |
Collaborator
Author
|
Ready! |
manno
approved these changes
Jul 12, 2020
elad-eyal
added a commit
to elad-eyal/frab
that referenced
this pull request
Sep 17, 2020
following frab#651 - migrating some conference might fail since mysql limits allowed_durations_minutes_csv to 255 characters
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address #608 and #304 :
Add a configurable set of event duration acceptable in cfp. The list of options is computed based on the "timeslot duration" and the "max number of timeslots". The "default event duration" is always acceptable. For conferences created before applying this PR, the default is that all duration are acceptable (same as legacy behavior). For new conferences, the default is that only the "default event duration" is allowed, and other durations need to be opt-in.
cfp event form is changed to only accept these values. Crew's event form is not affected.
cfp event form will not ask users to select duration if there is only 1 option available.
Rename "timeslots" to "duration" since we always present the value in minutes, never in timeslots.
Similar to "timeslot_duration" and "default event duration" : "allowed event durations" are configurable via the parent conference in case of a sub-conference.
Add validator, that a conference "default timeslot" (default duration) must be <= "max timeslots".