Merged
Conversation
pluck(:start_date).min raises an exception when any of its inputs are null. maximum() do the comarison in the database which ignores nulls. Exceptions in after_commit hook are ignored and this caused the conference import to not update correctly.
elad-eyal
force-pushed
the
fix_642
branch
2 times, most recently
from
fd85356 to
9205981
Compare
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #642
Fix exception in the welcome page, if there's a conference with
start_dateorend_date= null.Fix silenced exception if conference
start_dateandend_datecalculationAdd an integration test which created a conference, exports it, imports it to a new name, and compares the new and old copies. This test fails without the other fixes in this PR.
frab:conference_importworked by disabling many callbacks, but never enabled them back. This caused tests to fail (because necessary callbacks were disabled). Now the import will re-eanble the callbacks it disables.