Merged
Conversation
Collaborator
|
Wouldn't it be better to provide direct link as a substition I.e. %{eventpagelink} ? |
Contributor
Author
No. Imagine the link being https://conference.name/external-tool-checklist-%{event_id}.html. For example https://content.events.ccc.de/cfp/36c3/checklist-10816.html. I have rendered a handy overview page for each accepted event. |
Collaborator
|
👍 |
Contributor
Author
|
@eladeyal-intel Would you please do me the favour and add missing translations? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For last Congress, we prepared speaker-specific check lists that would link to their respective frab event pages. Those checklists were rendered per event.
But when sending out acceptance mails, there was no way to automatically link to the document, since the event-id could not be inserted.
This PR simply adds the event_id variable to the list of substitutable parameters.