Merged
Conversation
Collaborator
|
Some comments after reading the code (didn't try it yet)
|
Contributor
Author
|
Collaborator
|
@erdgeist I would think you'd want reviewers to see the history of the events they're reviewing, but not other events. I don't think it's important to track old review scores (on the contrary maybe). Anyway I'm not sure the reviews are integrated to paper-trail completely anyway. |
Contributor
Author
|
I see no easy way to exclude Ratings and Feedback. Updates types are saved as yaml key/value pairs deep in the PaperTrail version object with no efficient way to filter for them. That being said, I actually didn't find it distracting seeing these verbose updates in a live conference, as they do happen at very specific times in an event's life cycle, making it actually pleasing to follow it. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a "history" tab to the events view, listing all versions of the event and associated events.
It also cleans up the tabs on event views, so I didn't have to manually add the history tab to each of the others.
A review would be quite appreciated.