Skip to content

highlight late submissions#626

Merged
erdgeist merged 1 commit intofrab:masterfrom
elad-eyal:show_late_submissions
Nov 2, 2019
Merged

highlight late submissions#626
erdgeist merged 1 commit intofrab:masterfrom
elad-eyal:show_late_submissions

Conversation

@elad-eyal
Copy link
Collaborator

  1. Add ORANGE tag if event was submitted after cfp end; or RED tag if submitted after hard deadline. The tag appears in event lists in a short form, and in an explicit form in the event details page.

  2. Change creation date display to conference timezone.

see #490

image

image

Copy link
Contributor

@erdgeist erdgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notification is quite intrusive and I wonder if there's a way to snooze them. Sometimes you want to have the option of allowing a single late submission (by invitation, for example) and not be bothered by it anymore, once you declare that this single one ist okay.

I guess that the warnings in the list belong below "Created at" in list view and into its own list entry in the event details view, not clumped together with the State. That would also make it easier to completely switch off these labels per conference.

submitted_after_soft_deadline: Soumis après la date limite
short:
submitted_after_hard_deadline: En retard
submitted_after_soft_deadline: EN RETARD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These do not look right.

submitted_after_soft_deadline: Enviado após o prazo
short:
submitted_after_hard_deadline: Atrasado
submitted_after_soft_deadline: ATRASADO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These neither ;)

indicator:
full:
submitted_after_hard_deadline: Eingereicht nach harter Frist
submitted_after_soft_deadline: Eingereicht nach Fristablauf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from config/locales/de.yml, in German that would be "end_date: Enddatum
hard_deadline: Harte Einreichungsfrist"

And I guess, these translations break conventions in other languages, as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your feedback is not clear enough for me. The "indicator full" is the string going for the event page, and the "indicator short" is the text going to the list pages. I thought just writing "Late" is enough becasue I did not want it to be too verbose

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, the short version is okay. But the long version of the term "hard deadline" and "soft deadline" already has had other translations. And now these mismatch. I showed you with the German example. Other translations don't even show differences between the two translations.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So its

submitted_after_soft_deadline: Eingereicht nach Enddatum
submitted_after_hard_deadline: Eingereicht nach Harte Einreichungsfrist

?

@elad-eyal
Copy link
Collaborator Author

I moved the tag to the "created" column; so now it shows only on All Events and My events but not on attachmetns tab or event ratings tab

image

image

image

Change creation date display to conference timezone

see frab#490
@elad-eyal elad-eyal force-pushed the show_late_submissions branch from dc797c2 to 9346deb Compare November 2, 2019 21:40
@erdgeist erdgeist merged commit 5e60563 into frab:master Nov 2, 2019
@elad-eyal elad-eyal deleted the show_late_submissions branch November 3, 2019 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants