Filter then email by elad-eyal · Pull Request #583 · frab/frab

elad-eyal · 2019-10-09T20:39:56Z

allows user to filter events (in the all events / my events / ratings screen) and then send a mail template to people involved with those events.

Merge notes:

This must be based on More flexible mail templates #578 (because the change in email sending)

erdgeist · 2019-11-03T18:49:53Z

Okay, next PR. Can you please resolve the merge conflicts, so that I can review this one.

elad-eyal · 2019-11-03T19:04:07Z

@erdgeist Can we work on #578 first? #578 changed the way mass mails are sent.

elad-eyal · 2019-11-03T19:35:47Z

rebased!

app/models/event_person.rb

test/integration/view_event_test.rb

app/controllers/events_controller.rb

app/views/events/index.html.haml

runtest.sh

This changes "my events" to be a special case of "all events", with an additional query parameter "events=my" The old URL for "my events" is now a redirection, for some backward compatability. Old URLs for "my events" with filter or sort will lose the filter/sort. The benefit is that it will make bulk actions works seamlessly for both views.

see frab#570

see frab#577

elad-eyal force-pushed the filter_then_email branch 3 times, most recently from 1285a55 to e32cb6f Compare October 14, 2019 13:26

elad-eyal force-pushed the filter_then_email branch 4 times, most recently from 5653c34 to c98f1be Compare October 27, 2019 12:21

elad-eyal mentioned this pull request Oct 27, 2019

Bulk edit #582

Merged

elad-eyal force-pushed the filter_then_email branch 2 times, most recently from 7bef91b to eabf9e2 Compare November 2, 2019 10:41

elad-eyal force-pushed the filter_then_email branch from eabf9e2 to 45ccef6 Compare November 3, 2019 19:34