It would be great to rebase all of the PRs currently pending on master. Currently most of them seem to belong in a certain order and I can't merge the newer ones for lack of experience with what the earlier commits do.

Okay, time to rebase ;)

Looking through the patch, I see several UX sins already. My [x] hack has been bad enough and I've always wanted to replace it by some more intuitive way like the ❌ sign or other graphical element easy enough to spot. But hiding the comparison operator behind a toggle character is just way too unintuitive. I'd suggest (and later implement once this PR is aligned with master) to visually group each filter with a decent border and some darker fill, and make the operator a drop down:

X [ value ≥ 2 ]
[ value > 2 ]
[ value ≤ 2 ]

so that you immediately see that there are some options and what will be the option after you select it.

@erdgeist

How about this? The X icon removes the filter; the ⭮ icon cycles between ≥ = ≤ ; the link "multiple" opens the multi-value selector

Why would only "multiple" open the selector? Allowing the same on "Confirmed" in that case would add consistency to the interface. Also, why the ⭮ icon, if you can actually show what happens next (i.e. the operator that would be selected if you click on the right button)?

But besides that, I like where this is going. Really looks a lot tidier than my initial hack.

Even better: If there's only three operators, you can just put the two NOT currently selected in the box to the right so that you do not have hidden options.

What I still find irritating is that you can't change the numeric value we compare against. You have to manually look for an entry with a matching value to start this filter. From an interface perspective: Why would you use the "average of 3.4" as a starting point to compare against? Find the submissions that are equally(?) well ranked? Or find all submissions that are ranked better than the one shown here?

I come to think that since you obviously now have a good model of modals, clicking on these numbers in the list should open a modal allowing to select the operator and narrowing down the exact number to filter against. But maybe I mis-understood the workflow you had in mind.

We can have this:

and I can probably add the third operator ≥ as a second button next to the = so that there are no hidden options.

The behaviour I was thinking about is that the moderators will sort the submissions based on one criteria, then filter out everything worse, then continue. I'm having a bit of a trouble imagining a modal window that would make sense.

The more I think of it, the less sense makes adding a filter by clicking on the number. The way I see it would be to add a filter symbol next to the title of the column and then add a modal that behaves differently for counts (like the event rating count) and review averages.

I can see why you would want to select based on "worse than this average", e.g. so you can bulk-update them to rejected or send bulk mail. But I have a hard time imagining why you would want to filter "everything with more than two reviews" or "exactly two reviews", when you actually only would want to sort to see the ones that have received the least attention, so that they pop up at the top of the list.

While I am at it: I'm maintaining a companion tool for a while that does exactly what you're working on here and I've received quite some feedback on it. It gets the events per track from frab in a cron job, and then renders a list that can be filtered with a type-ahead filter, sorted by all review categories plus their combined average, sorted by the amount of reviews, sorted by the own review count (0 or 1) and sorted randomly – so that every reviewer can work through a different set of events when starting from the top).

The tool is here https://erdgeist.org/gitweb/c3rater/tree/ and if you drop me a DM, I can show you a link to a live demo version.

OK I almost got it:

Can you DM in GitHub? I didn't know. Can you e-mail me by adding changing my username - replace - to @ and add .com

I just noticed, there's even a public documentation for the tool :) https://content.events.ccc.de/rater.html

@erdgeist I updated this using modal filter window for both text and numeric.

This looks and works amazing. Just two more pixels below the filters bar and I'd merge it. :)

Just a little question, the "Showing XX of YY Events" we were talking about in #577 went away? Oh, I noticed, it was never part of the PR. Shall I add a new one for this feature?

I added a few pixels below the filter bar. is this what you mean?

I just noticed that when your session expires and you klick the filter icons, nothing happens (because the modal route is not answered?) until I reloaded the page and then was asked to log in again.

Looks like the last merge broke your CSS, a closing bracket is missing.

I just noticed that when your session expires and you klick the filter icons, nothing happens (because the modal route is not answered?) until I reloaded the page and then was asked to log in again.

I added a page refresh in case of modal load error; so in the case @erdgeist described, user will be presented with login screen instead of no response.

Looks like the last merge broke your CSS, a closing bracket is missing.

fixed

Amazing work. Thanks.

Thanks :-)