Submission Review (grading) with multiple metrics#557
Conversation
elad-eyal
force-pushed
the
review-metrics-v4
branch
6 times, most recently
from
88d8401 to
84eeaa4
Compare
elad-eyal
force-pushed
the
review-metrics-v4
branch
from
84eeaa4 to
81199c7
Compare
|
Added test for editing an event score's and checking that the average is calculated correctly. |
elad-eyal
force-pushed
the
review-metrics-v4
branch
5 times, most recently
from
8250016 to
e1e9686
Compare
elad-eyal
force-pushed
the
review-metrics-v4
branch
5 times, most recently
from
65d211f to
347cbe3
Compare
|
There's a lot going on in this PR that doesn't have to do with review metrics, like introduction of the assistant role and the concept of stakeholders. This makes it quite hard to review the review metrics part. Since I am not sure how this is supposed to work, anyway, I focussed on anything BUT the review metrics and this looks okay. |
elad-eyal
force-pushed
the
review-metrics-v4
branch
2 times, most recently
from
6677cc0 to
bddd5f1
Compare
|
elad-eyal
force-pushed
the
review-metrics-v4
branch
from
bddd5f1 to
de07364
Compare
|
rebased on master. Now this PR only includes relevant stuff |
elad-eyal
force-pushed
the
review-metrics-v4
branch
from
de07364 to
1bde179
Compare
elad-eyal
changed the title
| = f.simple_fields_for :review_scores do |ff| | ||
| = ff.input :score, | ||
| as: :radio_buttons, | ||
| collection: [[t('events_module.not_applicable'), '0'], ['1', '1'], ['2', '2'], ['3', '3'], ['4', '4'], ['5', '5']], |
There was a problem hiding this comment.
Does the zero value mean that you can undo a rating?
There was a problem hiding this comment.
Yes. The value 0 is displayed as N/A when rating; and as a "blank" when looking at the rating summary. It does not taken account when calculating average review.
|
I understand most of the PR now and see little changes that have the potential not be corrected easily if they contain mistakes I have not spotted. I wonder how good the interface will actually work in the event reviews pane, but these may also be patched up later. So from me that would be a go. Maybe @manno wants to comment, if not I'll merge after 24h. |
|
#614 is this pull + a modification to add_fake_data to create fake reviews, if you want to experiment with the GUI |
Prior to this change, it was not possible to save an event rating comment without specifying an event rating. This changes this so reviewer can now save the comment text and return later to complete the review. The event_rating counter will only count events with an event rating specified. "Start review" flow (where reviewer is presented with a series of events to review) also only considers a review with a rating as a complete review.
elad-eyal
force-pushed
the
review-metrics-v4
branch
from
1bde179 to
a7f3986
Compare
2 participants
see #518