configurable event types per conference#530
Merged
erdgeist merged 1 commit intofrab:masterfrom Oct 25, 2019
Merged
Conversation
elad-eyal
force-pushed
the
configurable_event_types
branch
from
b81e1ea to
a688e01
Compare
elad-eyal
force-pushed
the
configurable_event_types
branch
from
8cfa84a to
bdded68
Compare
elad-eyal
force-pushed
the
configurable_event_types
branch
2 times, most recently
from
d4e8a5f to
410d1ec
Compare
elad-eyal
force-pushed
the
configurable_event_types
branch
6 times, most recently
from
2f5e45f to
cb90874
Compare
elad-eyal
force-pushed
the
configurable_event_types
branch
from
cb90874 to
5affc44
Compare
Contributor
|
This looks like something that I would love to see, but the current PR is a mess. There's changes in 67 files, most of them having nothing to do with "configurable event types". If you manage to cherry pick those changes to a new PR, I will review and merge them before they start departing from master again. |
Conference settings now include two ways to express which event types are allowed. see frab#302
elad-eyal
force-pushed
the
configurable_event_types
branch
from
5affc44 to
6658b72
Compare
Collaborator
Author
|
@erdgeist - done. |
Contributor
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conference settings now include two ways to express which event types
are allowed.
First we have the same of event_types we had so far;
lecture workshop podium lightning_talk meeting film concert djset performance other. These names are localized when used. Each of these can be allowed/disallowed individually per conference. The default is that they are all allowed - same as before.Also, admin can add any number of additional types by specifying them in a semicolon delimited list. This list is not supposed to be localized.
I decided to store the allowed types as a string and not separate tables in the database in order to be less intrusive. For example admin can remove a type from the allowed types list; but any event with that type will keep it.
see #302