submission grading with multiple metrics#521
Closed
elad-eyal wants to merge 7 commits intofrab:masterfrom
Closed
Conversation
elad-eyal
force-pushed
the
review-metrics-v4
branch
from
46d267b to
90b9ee4
Compare
Collaborator
Author
|
elad-eyal
force-pushed
the
review-metrics-v4
branch
4 times, most recently
from
f2de984 to
060956f
Compare
Collaborator
Author
|
Prior to this change, it was not possible to save an event rating comment without specifying an event rating. This changes this so reviewer can now save the comment text and return later to complete the review. The event_rating counter will only count events with an event rating specified. "Start review" flow (where reviewer is presented with a series of events to review) also only considers a review with a rating as a complete review.
elad-eyal
force-pushed
the
review-metrics-v4
branch
from
060956f to
8679cbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #518