Merged
Conversation
The descriptive strings are currently only used in a view for the conference settings, under the heading 'additional features' with checkboxes beside them. From a logical point of view, writing "enabled" and having a checkbox is fairly redundant (if a checkbox is checked, something is active, after all); thus I propose removing the "enabled" bit of the string and have done this in all the languages whose characters I can decipher and know if the grammar would be impacted by a change. (Spoilers: it isn't for romance or germanic languages) Additionally, some of the strings were incorrectly referenced as 'expenses enabled', without the underscore, which I've supplied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The descriptive strings are currently only used in a view for the
conference settings, under the heading 'additional features' with
checkboxes beside them.
From a logical point of view, writing "enabled" and having a checkbox is
fairly redundant (if a checkbox is checked, something is active, after
all); thus I propose removing the "enabled" bit of the string and have
done this in all the languages whose characters I can decipher and know
if the grammar would be impacted by a change. (Spoilers: it isn't for
romance or germanic languages)
Additionally, some of the strings were incorrectly referenced as
'expenses enabled', without the underscore, which I've supplied.