Skip to content

Remove SMTP_NOTLS ENV Var#459

Merged
manno merged 1 commit intofrab:masterfrom
MaxRink:master
Feb 12, 2019
Merged

Remove SMTP_NOTLS ENV Var#459
manno merged 1 commit intofrab:masterfrom
MaxRink:master

Conversation

@MaxRink
Copy link
Contributor

@MaxRink MaxRink commented Feb 11, 2019

Remove the SMTP_TLS Enironment variable to restore the ability to use Mailservers with TLS enabled.
As described here ( #446 (comment) ) the existance of this Var disables TLS Support completely..
This change adds the ability to use TLS-Mail back into the Docker Image

Remove the SMTP_TLS Enironment variable to restore the ability to use Mailservers with TLS enabled.
@manno
Copy link
Member

manno commented Feb 12, 2019

@MaxRink is it still possible to use the Docker image without SMTP TLS? Not sure if someone is using that?

@MaxRink
Copy link
Contributor Author

MaxRink commented Feb 12, 2019

Well, the dockerfile curretnly in use sets the environment Variable "SMTP_NOTLS" to true.
I canoOverride this at launch to false but looking at the code that interprets the ENV-Vars ( https://github.com/frab/frab/blob/master/config/initializers/action_mailer.rb#L12 ) the sole presence of this variable in the environment disables TLS-Support for good, no matter what its actually set to.

And as far as i know there is no easy way to unset an env var defined in an dockerfile so the Variable needs to be dropped from the presets within the Dockerfile to get SMTP TLS working.
You can still define it at launch if you want to drop TLS Support tho.

And i know that that isn't the real solution to this Issue (i'd propose to change the handling of the ENV_Var to actually reflect the value, not just the existance) but its a quick fix that gets that working again.

@manno manno merged commit 21abb8b into frab:master Feb 12, 2019
@manno manno mentioned this pull request Feb 12, 2019
manno added a commit that referenced this pull request Feb 12, 2019
Together with #459 this should fix SMTP
issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants