Implementation of atomic and durable file writes:#48
Merged
snoyberg merged 1 commit intofpco:masterfrom Jul 12, 2019
Merged
Conversation
537d40b to
18e5e2a
Compare
* Durability of file writes with the help of `fsync()` syscall on the file and containing folder * Atomicity of file writes with the help of atomic renames with `rename()`, `renameat()` and `linkat()` syscalls, depending on how it was opened * Anonymous temp file utilization on Linux for atomic writes with the help of `openat()` and `O_TMPFILE` * Instead of merging this functionality into commercialhaskell/rio#167 it has been moved upstream into `unliftio` * Dropped support for ghc-7.8
fff2eba to
f64ec22
Compare
snoyberg
approved these changes
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fsync()syscallrename(),renameat()andlinkat()syscallshelp of
openat()andO_TMPFILE@snoyberg The whole PR from commercialhaskell/rio#167 was transfered here almost verbatim, with an exception of some renames and haddock adjustments. The new module
UnliftIO.IO.Fileis very heavy on haddock, therefore I though it be better to have it as a separate module, rather than cramming everything intoUnliftIO.IO.CC @nh2 (Thanks for review and guidance)