Conversation
- Ignored size when rotating tiles because they are now positioned using their center points rather than their top-left corners - Added handling for all of the new shape types supported by regions except `GridShapeData`, because there doesn't seem to be a way to rotate those without potentially losing data - Fixed some calls to deprecated wall edge methods in V14 - Fixed animating tile movement in V14 Closes #6925
arbron
added
compatibility
Fyorl
reviewed
Apr 14, 2026
dev7355608
requested changes
Apr 14, 2026
dev7355608
left a comment
dev7355608
left a comment
Contributor
There was a problem hiding this comment.
This behavior should probably be its own module, I think. It doesn't seem like it essential to play dnd5e or dnd5e specific to me.
- Use core's shape rotation in V14 rather than home-grown version, revert improvements to `rotateRegionShapes` since they aren't needed anymore - Swap token movement to use `moveTokens` in V14 rather than direct update - Use `shape.center` in V14 rather than custom logic - Split token animations into their own `Token#animate` calls rather than handling manually - Don't call refresh to `canvas.perception` in V14
|
just tested this, works great except for lights that don't have their emission angle set to 360, those lights get moved by an offset. |
dev7355608
requested changes
Apr 17, 2026
dev7355608
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GridShapeData, because there doesn't seem to be a way to rotate those without potentially losing dataCloses #6925