[#6708] Add makeChange option to getActorCurrencyUpdates#6762
Merged
Conversation
- Break higher-denomination coins when the target denomination is unavailable - Respects existing `priority` parameter for coin selection order Closes foundryvtt#6708
makeChange option to getActorCurrencyUpdatesmakeChange option to getActorCurrencyUpdates
arbron
requested changes
Feb 25, 2026
- Extract `CurrencyUpdateOption`s typedef to `_types.mjs` - Replace inline option JSDoc with typedef on both `deductActorCurrency` and `getActorCurrencyUpdates` - Default `makeChange` to true
Fyorl
requested changes
Feb 25, 2026
Co-authored-by: Kim Mantas <[email protected]>
- Convert CRLF -> LF
Fyorl
approved these changes
Feb 25, 2026
Fyorl
left a comment
Contributor
There was a problem hiding this comment.
Don't feel strongly about whether this should be breaking or not. Means we don't need any code change for bastion deduction at least.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
priorityparameter for coin selection orderCloses #6708