[#6376] Redesign Roll Table sheet using dnd5e2 styling#6377
Conversation
Fyorl
added
compatibility
Implements a system version of the roll table sheet that uses the system's styling. This doesn't both rewriting the HTML, but makes certain targeted changes on render to ensure the proper classes are added and the dnd5e checkboxes are used. Core's edit/view toggle is replaced with an edit slider in the header like other 5e sheets. In order to make this easier, some of the system's mode toggle code was changed to be more similar to how core's sheet is implemented (adding `isEditMode` property and using a `changeMode` action rather than a direct listener. None of these should be breaking changes. Some changes were also made to sheet styles to make them more widely available and item's `.item-image` header styling was made into a more generic `.document-image` to be usable across sheets. Closes #6376
58acc4d to
5f9438e
Compare
Fyorl
left a comment
Fyorl
left a comment
There was a problem hiding this comment.
Looks really good. Some style nitpicks:
Non-transparent background here, if you notice behind the rounded corner:
Would be nice to get these controls on a single line:
In dark mode these inputs blend into the odd row background colour. Sometimes we do that on purpose, but in this context of a table with alternating row colours, it looks weird. These probably need to be given a translucent black background.
These row backgrounds don't go to the end of the row on the right:
Can we use dnd5e-icons for these SVGs so that we can give them more appropriate colours for dark mode?
The table description is row-wise rather than columnar:
I also noticed that the summary tab doesn't absorb extra space when the sheet is resized, but that seems to be an issue for the core sheet too.
This is the result of
I made this swap, but it doesn't help with the default icons because the core SVG that is used doesn't have the necessary |
|
Hmm, swapping to |
Fyorl
left a comment
Fyorl
left a comment
There was a problem hiding this comment.
Hmm, swapping to
dnd5e-iconalso means thateditImagedoesn't work because it deliberately throw an error when used on anything but an<img>element.
That's fine, let's pull this change out. It's not something that we need to fix.
2 participants
Implements a system version of the roll table sheet that uses the system's styling. This doesn't bother rewriting the HTML, but makes certain targeted changes on render to ensure the proper classes are added and the dnd5e checkboxes are used.
Core's edit/view toggle is replaced with an edit slider in the header like other 5e sheets. In order to make this easier, some of the system's mode toggle code was changed to be more similar to how core's sheet is implemented (adding
isEditModeproperty and using achangeModeaction rather than a direct listener. None of these should be breaking changes.Some changes were also made to sheet styles to make them more widely available and item's
.item-imageheader styling was made into a more generic.document-imageto be usable across sheets.Closes #6376