Skip to content

Add creature fallback in lookup enrichers#6353

Merged
arbron merged 3 commits into
foundryvtt:5.3.xfrom
Sayshal:pack-fix-2
Mar 2, 2026
Merged

Add creature fallback in lookup enrichers#6353
arbron merged 3 commits into
foundryvtt:5.3.xfrom
Sayshal:pack-fix-2

Conversation

@Sayshal

@Sayshal Sayshal commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Closes #6291

@Fyorl Fyorl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the features on the monsters themselves need this fallback? I would think probably not since they should always resolve. But I suppose if new monsters are created by dragging the monster features then they would end up with these fallbacks anyway.

At the very least it would reduce the size of this diff I suppose.

@Fyorl
Fyorl changed the base branch from 5.2.x to 5.3.x March 2, 2026 20:22
@arbron

arbron commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

I'm wondering if we want to change this to be {monster} rather than {creature} because monster features regularly use creature to mean the target of the ability, so using creature as the fallback may result in some confusing wording.

See Swallow:
"If the creature takes 30 damage or more on a single turn from the swallowed creature, the creature must succeed…"

vs

"If the monster takes 30 damage or more on a single turn from the swallowed creature, the monster must succeed…"

@Sayshal

Sayshal commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

I'm wondering if we want to change this to be {monster} rather than {creature} because monster features regularly use creature to mean the target of the ability, so using creature as the fallback may result in some confusing wording.

That makes sense, yeah. I can submit an update in a little bit here.

@Sayshal

Sayshal commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

Do the features on the monsters themselves need this fallback? I would think probably not since they should always resolve. But I suppose if new monsters are created by dragging the monster features then they would end up with these fallbacks anyway.

At the very least it would reduce the size of this diff I suppose.

I don't feel strongly either way and can make the revisions if that's what we want. Having the fallback is nice so when imported and then dragged to an actor it's more readable.

Either way - not ready for merge yet as I found a few more instances of lookups without fallbacks.

@Sayshal

Sayshal commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

Alright. 474 more adjustments - my regex searching wasn't catching the way YAML wraps lines. ALL monsters & monster features now have a fallback. Features I think is a good choice as mentioned above.

@arbron arbron added this to the D&D5E 5.3.0 milestone Mar 2, 2026
@arbron
arbron merged commit e98ac89 into foundryvtt:5.3.x Mar 2, 2026
@Sayshal
Sayshal deleted the pack-fix-2 branch March 2, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make use of the lookup enricher's fallback in Monster Features

3 participants