[#4708] Rebuild ItemGrantFlow for V2#6241
Merged
Merged
Conversation
arbron
added
ui
21 tasks
arbron
force-pushed
the
advancement/flow-v2
branch
from
September 26, 2025 22:47
9fb8eaf to
5afe465
Compare
arbron
force-pushed
the
advancement/item-grant-v2
branch
from
September 26, 2025 22:57
1a6abf6 to
202fefa
Compare
Collaborator
Author
|
More compact layout: 
|
arbron
force-pushed
the
advancement/flow-v2
branch
from
October 15, 2025 22:14
5afe465 to
ab9c58a
Compare
arbron
force-pushed
the
advancement/item-grant-v2
branch
from
October 15, 2025 22:17
202fefa to
4586b93
Compare
arbron
force-pushed
the
advancement/flow-v2
branch
from
February 3, 2026 01:13
ab9c58a to
d9fa863
Compare
arbron
force-pushed
the
advancement/item-grant-v2
branch
from
February 3, 2026 01:20
4586b93 to
db8e9d2
Compare
Fyorl
force-pushed
the
advancement/flow-v2
branch
from
February 4, 2026 01:12
d9fa863 to
b89ae52
Compare
Rework `ItemGrantFlow` for application V2, leaving the original application around so that `ItemChoiceFlow` and module-provided advancement types that also extend it won't immediately break. The interface has been reworked to show each item added in a pill and surround the ability select, if required, in a fieldset.
arbron
force-pushed
the
advancement/item-grant-v2
branch
from
February 5, 2026 20:46
db8e9d2 to
193dd6d
Compare
Fyorl
requested changes
Feb 6, 2026
Fyorl
left a comment
Fyorl
left a comment
Contributor
There was a problem hiding this comment.
Looks good; there was one issue I found in testing. Repro steps are:
- Create or modify an existing Item Grant to grant one optional and one non-optional feature.
- Complete that level of advancement on a character, opting-out of the optional feature.
- Modify choices for that level and attempt to select the optional feature this time.
For me, the box would not become checked, and it resulted in an error thrown when attempting to complete the advancement.
| this.updateSource({[keyPath.replace(/\.([\w\d]+)$/, ".-=$1")]: null}); | ||
|
|
||
| if ( options.uuid ) this.updateSource({ [keyPath]: added }); | ||
| else this.updateSource({ [keyPath.replace(/\.([\w\d]+)$/, ".-=$1")]: null }); |
Contributor
There was a problem hiding this comment.
Will be a lot easier to do this with ForcedDeletion in v14
Fyorl
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework
ItemGrantFlowfor application V2, leaving the original application around so thatItemChoiceFlowand module-provided advancement types that also extend it won't immediately break.The interface has been reworked to show each item added in a pill and surround the ability select, if required, in a fieldset.