Skip to content

[#4708] Rebuild HitPointsFlow for V2#6239

Merged
arbron merged 5 commits into
5.3.xfrom
advancement/hit-points-v2
Feb 10, 2026
Merged

[#4708] Rebuild HitPointsFlow for V2#6239
arbron merged 5 commits into
5.3.xfrom
advancement/hit-points-v2

Conversation

@arbron

@arbron arbron commented Sep 24, 2025

Copy link
Copy Markdown
Collaborator

Rework HitPointsFlow for application V2. The new interface now displays the hit points calculation that is occuring including the ability modifier and per-level bonuses.

Screenshot 2025-09-24 at 15 44 17

@arbron arbron self-assigned this Sep 24, 2025
@arbron arbron added ui User interface related features or bugs in progress priority: high labels Sep 25, 2025
@arbron

arbron commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator Author

Stuck the checkbox into a fieldset:

Screenshot 2025-09-24 at 19 35 07

@arbron
arbron force-pushed the advancement/flow-v2 branch from 9fb8eaf to 5afe465 Compare September 26, 2025 22:47
@arbron
arbron force-pushed the advancement/hit-points-v2 branch from 0b78632 to 8346703 Compare September 26, 2025 23:03
@arbron arbron added this to the D&D5E 5.3.0 milestone Oct 7, 2025
@arbron
arbron force-pushed the advancement/flow-v2 branch from 5afe465 to ab9c58a Compare October 15, 2025 22:14
@arbron
arbron force-pushed the advancement/hit-points-v2 branch from 8346703 to 78a9d90 Compare October 15, 2025 22:15
Aioros added a commit to Aioros/dnd5e that referenced this pull request Oct 31, 2025
@arbron
arbron force-pushed the advancement/flow-v2 branch from ab9c58a to d9fa863 Compare February 3, 2026 01:13
@arbron
arbron force-pushed the advancement/hit-points-v2 branch from 78a9d90 to 164daf9 Compare February 3, 2026 01:19
@Fyorl
Fyorl force-pushed the advancement/flow-v2 branch from d9fa863 to b89ae52 Compare February 4, 2026 01:12
Base automatically changed from advancement/flow-v2 to 5.3.x February 5, 2026 20:43
Rework `HitPointsFlow` for application V2. The new interface now
displays the hit points calculation that is occuring including the
ability modifier and per-level bonuses.
@arbron
arbron force-pushed the advancement/hit-points-v2 branch from 164daf9 to 931cbad Compare February 5, 2026 20:46
@arbron
arbron requested a review from Fyorl February 5, 2026 20:48
Comment thread templates/advancement/hit-points-flow.hbs Outdated
Comment thread module/applications/advancement/hit-points-flow.mjs Outdated
Comment thread module/applications/advancement/hit-points-flow.mjs
@arbron
arbron requested a review from Fyorl February 6, 2026 23:51

@Fyorl Fyorl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one issue, but good to go once that's resolved. If you advance past the hit points advancement and then go back, clicking the 'take average' checkbox will update the calculation, but the checkbox itself stays checked. You should notice the same if you advance several levels and then attempt to modify choices.

@XXDarrienX

Copy link
Copy Markdown

A suggestion to this, an extra button to auto set max hp instead of rolling or taking average?

@arbron
arbron merged commit be879ac into 5.3.x Feb 10, 2026
@arbron
arbron deleted the advancement/hit-points-v2 branch February 10, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in progress priority: high system: advancement ui User interface related features or bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants