[#4708] Rebuild ScaleValueFlow & SizeFlow for V2#6055
Merged
Conversation
arbron
added
ui
21 tasks
Contributor
|
Is the text on the Size advancement preset from the system? If so, think there might be a spelling mistake 😭 |
Contributor
No, that's a custom hint in an advancement. |
arbron
force-pushed
the
advancement/flow-v2
branch
from
September 24, 2025 21:19
3455080 to
9fb8eaf
Compare
arbron
force-pushed
the
advancement/scale-v2
branch
from
September 24, 2025 21:21
ba8b4fa to
968ab78
Compare
arbron
force-pushed
the
advancement/flow-v2
branch
from
September 26, 2025 22:47
9fb8eaf to
5afe465
Compare
arbron
force-pushed
the
advancement/scale-v2
branch
from
September 26, 2025 23:01
968ab78 to
6253180
Compare
arbron
force-pushed
the
advancement/flow-v2
branch
from
October 15, 2025 22:14
5afe465 to
ab9c58a
Compare
arbron
force-pushed
the
advancement/scale-v2
branch
from
October 15, 2025 22:15
6253180 to
cb1ba73
Compare
arbron
force-pushed
the
advancement/flow-v2
branch
from
February 3, 2026 01:13
ab9c58a to
d9fa863
Compare
arbron
force-pushed
the
advancement/scale-v2
branch
from
February 3, 2026 01:17
cb1ba73 to
c0c0912
Compare
Fyorl
force-pushed
the
advancement/flow-v2
branch
from
February 4, 2026 01:12
d9fa863 to
b89ae52
Compare
Reworked `ScaleValueFlow` & `SizeFlow` for application V2. Scale value flow just has some minor tweaks to move the scale value changes to the center. Size flow gets the select dropdown moved into a fieldset to match other advancement types with a single choice. Closes #4708
arbron
force-pushed
the
advancement/scale-v2
branch
from
February 5, 2026 20:44
c0c0912 to
f1f5b5b
Compare
Fyorl
approved these changes
Feb 10, 2026
Fyorl
left a comment
Fyorl
left a comment
Contributor
There was a problem hiding this comment.
Found one issue but good to go otherwise. If you advance past a size advancement and then return back to it, the form does restore the size that was picked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked
ScaleValueFlow&SizeFlowfor application V2. Scale value flow just has some minor tweaks to move the scale value changes to the center. Size flow gets the select dropdown moved into a fieldset to match other advancement types with a single choice.