[#4708] Deprecate AdvancementSelection in favor of createDialog#5228
Merged
Conversation
Deprecates the V1 `AdvancementSelection` dialog in favor of using `PseudoDocument#createDialog` same as activities. To fully support using advancements with this method a few changes were made: - Added support for proper coloring of SVG icons - Added optional `hint` that is added as tooltip - Added ability to disable options without removing them - Split some logic out from the `createDialog` method into `_createDialogTypes` and `_createDialogData` methods so each type can customize the dialog behavior
Fyorl
force-pushed
the
4.4.x
branch
2 times, most recently
from
March 5, 2025 15:07
ecdba9c to
52777c2
Compare
Fyorl
force-pushed
the
4.4.x
branch
2 times, most recently
from
March 21, 2025 14:38
338f711 to
6710279
Compare
21 tasks
Fyorl
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates the V1
AdvancementSelectiondialog in favor of usingPseudoDocument#createDialogsame as activities. To fully support using advancements with this method a few changes were made:hintthat is added as tooltipcreateDialogmethod into_createDialogTypesand_createDialogDatamethods so each type can customize the dialog behavior