[#4708] Redesign AdvancementMigrationDialog for V2 app & styles#5227
Merged
Conversation
Convert `AdvancementMigrationDialog` to use `Dialog5e` and the V2 styles.
21 tasks
Fyorl
force-pushed
the
4.4.x
branch
2 times, most recently
from
March 5, 2025 15:07
ecdba9c to
52777c2
Compare
Fyorl
force-pushed
the
4.4.x
branch
2 times, most recently
from
March 21, 2025 14:38
338f711 to
6710279
Compare
Fyorl
approved these changes
Mar 21, 2025
Fyorl
reviewed
Mar 21, 2025
| * @throws | ||
| */ | ||
| static async createDialog(item, advancements) { | ||
| console.log("AdvancementMigrationDialog#createDialog", advancements); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert
AdvancementMigrationDialogto useDialog5eand the V2 styles.