[#5152] Create new usage message and migrate existing messages#5153
Conversation
arbron
added
api
migration
ecdba9c to
52777c2
Compare
338f711 to
6710279
Compare
7f3a393 to
d6936bb
Compare
dc12c96 to
054e58d
Compare
Fyorl
left a comment
Fyorl
left a comment
There was a problem hiding this comment.
Good change, feels cleaner. I did notice quite a few places that we are still referencing the use flags, like concentrationId, enchantmentProfile, etc. Is the intention that these stay as flags?
Also some lingering references to the now-migrated flags:
activity/mixin.mjsL275, 276, 721, 1008activity/summon.mjsL81
Adds a new `usage` message type that stores the usage cause, consumption deltas, and appliable effects in its system data. A migration has been added to convert all existing messages with the `flags.dnd5e.messageType` set to `usage` to this new message type and move any other flag data into the system data. Closes #5152
Fyorl
left a comment
Fyorl
left a comment
There was a problem hiding this comment.
Just wanted to re-iterate my comment about what the plan is for the other use flags we still have like spellLevel, concentrationId, enchantmentProfile, etc., in case you missed it.
Moved |
3 participants
Adds a new
usagemessage type that stores the usage cause, consumption deltas, and appliable effects in its system data. A migration has been added to convert all existing messages with theflags.dnd5e.messageTypeset tousageto this new message type and move any other flag data into the system data.Closes #5152