[#4708] Redesign TraitConfig for V2 app and styles#4769
Merged
Conversation
21 tasks
arbron
force-pushed
the
advancement/size-v2
branch
from
January 10, 2025 16:46
d71695e to
9c8bc6b
Compare
arbron
force-pushed
the
advancement/trait-v2
branch
from
January 15, 2025 22:43
05a6e3e to
406c8a5
Compare
Fyorl
force-pushed
the
advancement/size-v2
branch
from
January 17, 2025 16:50
9c8bc6b to
56feb4c
Compare
Fyorl
force-pushed
the
advancement/trait-v2
branch
from
January 17, 2025 16:57
406c8a5 to
f56d6eb
Compare
arbron
force-pushed
the
advancement/size-v2
branch
2 times, most recently
from
January 17, 2025 17:32
9c8bc6b to
4a191c7
Compare
Converts `TraitConfig` to `ApplicationV2` and the V2 system styles. Modifies `dnd5e-checkbox` to not throw `input` or `change` events when programatically setting the `checked` value, because that causes the form's `onChange` handler to trigger which causes the form to re-render, leading to an infinite loop. This brings `dnd5e-checkbox` in line with standard HTML checkboxes which only trigger these events on user interaction.
arbron
force-pushed
the
advancement/trait-v2
branch
from
January 17, 2025 17:34
f56d6eb to
7acdd88
Compare
Fyorl
requested changes
Jan 17, 2025
Fyorl
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
TraitConfigtoApplicationV2and the V2 system styles.Modifies
dnd5e-checkboxto not throwinputorchangeevents when programatically setting thecheckedvalue, because that causes the form'sonChangehandler to trigger which causes the form to re-render, leading to an infinite loop. This bringsdnd5e-checkboxin line with standard HTML checkboxes which only trigger these events on user interaction.