[#4708] Redesign ScaleValueConfig for V2#4767
Merged
Merged
Conversation
21 tasks
arbron
force-pushed
the
advancement/asi-v2
branch
from
January 10, 2025 16:22
c2b5acf to
0e11138
Compare
arbron
force-pushed
the
advancement/scale-v2
branch
from
January 10, 2025 16:40
e2deffe to
5f7fd29
Compare
Converts `ScaleValueConfig` to `ApplicationV2` and the V2 system styles. In order to take advantage of new form rendering this now automatically creates all the necessary fields in the scale value list using the schema data, rather than manually handling each scale value type.
Fyorl
force-pushed
the
advancement/scale-v2
branch
from
January 17, 2025 16:47
5f7fd29 to
4caacc0
Compare
Fyorl
approved these changes
Jan 17, 2025
| return levels.reduce((obj, level) => { | ||
| obj[level] = { placeholder: this._formatPlaceholder(lastValue), value: null }; | ||
| const value = this.advancement.configuration.scale[level]; | ||
| const value = this.advancement.configuration.scale[level]?.clone(); |
Contributor
There was a problem hiding this comment.
We didn't have to clone before?
Collaborator
Author
There was a problem hiding this comment.
I believe we previously had a small issue where _mergeScaleValues was making changes to the data on the advancement rather than just preparing changes for preview.
arbron
force-pushed
the
advancement/scale-v2
branch
from
January 17, 2025 17:30
4caacc0 to
9ecfad5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
ScaleValueConfigtoApplicationV2and the V2 system styles. In order to take advantage of new form rendering this now automatically creates all the necessary fields in the scale value list using the schema data, rather than manually handling each scale value type.