[#4708] Redesign AbilityScoreImprovementConfig for V2#4766
Merged
Conversation
21 tasks
arbron
force-pushed
the
advancement/choice-v2
branch
3 times, most recently
from
January 7, 2025 22:06
c7d2098 to
ab9100b
Compare
Fyorl
force-pushed
the
advancement/choice-v2
branch
from
January 10, 2025 00:22
ab9100b to
aef4811
Compare
Converts `AbilityScoreImprovementConfig` to `ApplicationV2` and the V2 system styles. Adds `PseudoDocumentSheet#submit` to be able to programmatically submit pseudo document forms.
arbron
force-pushed
the
advancement/asi-v2
branch
from
January 10, 2025 16:22
c2b5acf to
0e11138
Compare
Collaborator
Author
|
@Fyorl I was also considering a horizontal arrangement, not sure which I prefer (this does give more header space): 
|
Fyorl
approved these changes
Jan 16, 2025
Fyorl
left a comment
Fyorl
left a comment
Contributor
There was a problem hiding this comment.
Definitely prefer the vertical design. I wasn't sure about how the raised, legend-less fieldset looked with all the content floating in the middle so I did a style pass and also swept up a few issues that I would have otherwise left comments on.
If you really hate it let me know. I had some other ideas too. Otherwise feel free to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
AbilityScoreImprovementConfigtoApplicationV2and the V2 system styles. AddsPseudoDocumentSheet#submitto be able to programmatically submit pseudo document forms.