[#4708] Convert AdvancementManager to V2 app & styles#4765
Merged
Conversation
21 tasks
arbron
force-pushed
the
advancement/manager-v2
branch
from
November 25, 2024 22:01
28c0f91 to
aadf852
Compare
Fyorl
approved these changes
Jan 7, 2025
Fyorl
left a comment
Fyorl
left a comment
Contributor
There was a problem hiding this comment.
Worth re-evaluating the public and protected API for this class. For example, I imagine it's useful for a subclass to be able to read the #stepIndex or #advancing state. I'm not exactly sure what sort of use cases we have in mind for AdvancementManager subclasses though. Is it more superficial things like 're-skinning', or should a subclass be able to do things like modify how a user moves through the process entirely?
Converts `AdvancementManager` to use `ApplicationV2` and V2 system styles. Because old V1 advancement flow applications are embedded within this application, there are some V1 classes added to ensure that styling of old flows aren't completely broken. This also takes a number of soft-private properties and methods on the manager and makes them hard-private.
arbron
force-pushed
the
advancement/manager-v2
branch
from
January 7, 2025 18:01
6a5c6fc to
8d368d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
AdvancementManagerto useApplicationV2and V2 system styles. Because old V1 advancement flow applications are embedded within this application, there are some V1 classes added to ensure that styling of old flows aren't completely broken.This also takes a number of soft-private properties and methods on the manager and makes them hard-private.