[#4708] Redesign ItemGrantConfig for V2, implement drag-drop#4722
Merged
Conversation
21 tasks
arbron
force-pushed
the
advancement/grant-v2
branch
from
November 23, 2024 18:22
45e5a99 to
4f66cf2
Compare
arbron
force-pushed
the
advancement/config-v2
branch
from
January 6, 2025 21:41
f0049ff to
6f4e988
Compare
arbron
force-pushed
the
advancement/grant-v2
branch
from
January 6, 2025 21:47
4f66cf2 to
7df23f7
Compare
Fyorl
approved these changes
Jan 7, 2025
| @@ -0,0 +1,28 @@ | |||
| <section> | |||
| {{~#if showSpellConfig}} | |||
Contributor
There was a problem hiding this comment.
In v13 we have the ability to dynamically add parts when rendering, which will be useful here. We'll have to stick with this while we maintain v12 support though.
Converts `ItemGrantConfig` to use `ApplicationV2` and implements drag & drop functionality on the advancement sheets.
arbron
force-pushed
the
advancement/grant-v2
branch
from
January 7, 2025 21:53
7df23f7 to
9db4331
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
ItemGrantConfigto useApplicationV2and implements drag & drop functionality on the advancement sheets.