[#4708] Redesign AdvancementConfig & HitPointsConfig for V2#4709
Merged
Conversation
arbron
force-pushed
the
advancement/config-v2
branch
from
November 13, 2024 22:07
a396b25 to
7d162ae
Compare
21 tasks
Fyorl
approved these changes
Jan 6, 2025
Creates `AdvancementConfigV2` based on `ApplicationV2` and converts `HitPointsConfig` to use the new application and styles. Shared functionality between this application and the activity sheets has been moved into a new `PseudoDocumentSheet` class to avoid duplication. Also uses the `PseudoDocumentMixin` for advancement to get a number of improvements that were added for activities.
arbron
force-pushed
the
advancement/config-v2
branch
from
January 6, 2025 21:41
f0049ff to
6f4e988
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates
AdvancementConfigV2based onApplicationV2and convertsHitPointsConfigto use the new application and styles. Shared functionality between this application and the activity sheets has been moved into a newPseudoDocumentSheetclass to avoid duplication.Also uses the
PseudoDocumentMixinfor advancement to get a number of improvements that were added for activities.