Skip to content

[#1554] Add flags to advancements#2148

Merged
arbron merged 2 commits into
foundryvtt:5.3.xfrom
arbron:advancement/flags
Feb 11, 2026
Merged

[#1554] Add flags to advancements#2148
arbron merged 2 commits into
foundryvtt:5.3.xfrom
arbron:advancement/flags

Conversation

@arbron

@arbron arbron commented Feb 3, 2023

Copy link
Copy Markdown
Collaborator

Adds flags and the getFlag, setFlag, unsetFlag methods to Advancement.

Resolves #1554

@arbron arbron added this to the D&D5E 2.2.0 milestone Feb 3, 2023
@arbron arbron self-assigned this Feb 3, 2023
@arbron arbron linked an issue Feb 3, 2023 that may be closed by this pull request
@arbron arbron modified the milestones: D&D5E 2.2.0, D&D5E 2.3.0 May 13, 2023
@arbron
arbron force-pushed the advancement/flags branch from 58cc369 to 5fe5476 Compare May 26, 2023 15:36
@arbron
arbron force-pushed the advancement/flags branch from 5fe5476 to ad6dafc Compare July 21, 2023 16:38
@arbron
arbron changed the base branch from 2.2.x to 2.3.x July 21, 2023 16:38
@Fyorl

Fyorl commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

In principle this makes sense to do, but once we open the floodgates, there's no closing them. My concern here is that we're leaning too hard into 'Advancements are Documents' without them actually being Documents. It's convenient to use familiar APIs, but ultimately Advancements cannot be updated atomically, they propagate their updates up to the parent Item, and I don't want to be left with another mini-unlinked-token situation on our hands again.

I think I would have more confidence here if we had some concrete use-cases of what Advancement flags would be needed for. It would allow us to weigh the costs of attempting to accommodate those use-cases in some other way.

@Fyorl Fyorl modified the milestones: D&D5E 2.3.0, D&D5E 2.4.0 Aug 9, 2023
@arbron arbron removed this from the D&D5E 2.4.0 milestone Oct 20, 2023
@arbron
arbron changed the base branch from 2.3.x to 3.3.x June 24, 2024 17:06
@arbron
arbron changed the base branch from 3.3.x to 4.4.x March 5, 2025 18:02
@Fyorl
Fyorl force-pushed the 4.4.x branch 2 times, most recently from 338f711 to 6710279 Compare March 21, 2025 14:38
@Fyorl
Fyorl force-pushed the 4.4.x branch 2 times, most recently from 7f3a393 to d6936bb Compare April 4, 2025 14:48
@arbron
arbron changed the base branch from 4.4.x to 5.0.x May 5, 2025 21:04
@arbron
arbron force-pushed the advancement/flags branch from ad6dafc to 0c3269b Compare May 5, 2025 21:06
@arbron
arbron changed the base branch from 5.0.x to 5.1.x July 8, 2025 22:31
@arbron
arbron changed the base branch from 5.1.x to 5.2.x October 15, 2025 22:18
@arbron
arbron changed the base branch from 5.2.x to 5.3.x January 26, 2026 18:08
@arbron arbron added this to the D&D5E 5.3.0 milestone Feb 11, 2026
@arbron
arbron merged commit 28dde73 into foundryvtt:5.3.x Feb 11, 2026
@arbron
arbron deleted the advancement/flags branch February 11, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add flags to advancement data

2 participants