[#1554] Add flags to advancements#2148
Merged
Merged
Conversation
arbron
force-pushed
the
advancement/flags
branch
from
July 21, 2023 16:38
5fe5476 to
ad6dafc
Compare
Contributor
|
In principle this makes sense to do, but once we open the floodgates, there's no closing them. My concern here is that we're leaning too hard into 'Advancements are Documents' without them actually being Documents. It's convenient to use familiar APIs, but ultimately Advancements cannot be updated atomically, they propagate their updates up to the parent Item, and I don't want to be left with another mini-unlinked-token situation on our hands again. I think I would have more confidence here if we had some concrete use-cases of what Advancement flags would be needed for. It would allow us to weigh the costs of attempting to accommodate those use-cases in some other way. |
Fyorl
force-pushed
the
4.4.x
branch
2 times, most recently
from
March 21, 2025 14:38
338f711 to
6710279
Compare
Fyorl
force-pushed
the
4.4.x
branch
2 times, most recently
from
April 4, 2025 14:48
7f3a393 to
d6936bb
Compare
arbron
force-pushed
the
advancement/flags
branch
from
February 10, 2026 17:51
e71a158 to
3c48887
Compare
Fyorl
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds flags
and thetogetFlag,setFlag,unsetFlagmethodsAdvancement.Resolves #1554