This was originally found when upgrading Ember to version 0.4.2 but I am able to reproduce it with just the system in a plain test world. After upgrading the system to version 5.2 (I specifically used 5.2.4), the group actor's travel paces are blank. Something is wrong with the migration code.
Steps:
- Start with dnd5e version 5.1.10
- Create a new Group actor (I added a couple members, probably not necessary)
- Edit their travel speeds, adding a 2 for Land and 1 for Water
- Update the dnd5e system to version 5.2.4 and launch the world
- Login and wait for the system migration to finish
- Open the Group actor and check their Travel Pace
The Travel Pace has empty values for Land and Water instead of the 2 and 1 that were there before.
After upgrading, I looked at the actor's source data in the console and the system.attributes.travel looks like default values. Looking at the migration code, my best guess is that this line is where the error is:
https://github.com/foundryvtt/dnd5e/blob/release-5.2.4/module/data/actor/group.mjs#L127
It assigns a local variable but uses an empty object if it's not there. But if it wasn't there, that new object isn't assigned back to source. The rest of the migration code seems to be fine. I copied it to a macro and ran it on 5.1.10 to see what it was doing and doing a quick console.log(travel); at the end looked good.
This was originally found when upgrading Ember to version 0.4.2 but I am able to reproduce it with just the system in a plain test world. After upgrading the system to version 5.2 (I specifically used 5.2.4), the group actor's travel paces are blank. Something is wrong with the migration code.
Steps:
The Travel Pace has empty values for Land and Water instead of the 2 and 1 that were there before.
After upgrading, I looked at the actor's source data in the console and the
system.attributes.travellooks like default values. Looking at the migration code, my best guess is that this line is where the error is:https://github.com/foundryvtt/dnd5e/blob/release-5.2.4/module/data/actor/group.mjs#L127
It assigns a local variable but uses an empty object if it's not there. But if it wasn't there, that new object isn't assigned back to
source. The rest of the migration code seems to be fine. I copied it to a macro and ran it on 5.1.10 to see what it was doing and doing a quickconsole.log(travel);at the end looked good.