feat(tracing): consolidate trace options - #15665
Merged
Merged
Conversation
…el is available When an address appears as a parameter in a decoded trace and has a label, it currently renders as `LabelName: [0xAddr]`. The new `--compact-labels` flag shows only the label name, making traces more readable when addresses are already identified. Available in `cast run`, `cast call`, `forge test`, and `forge script`. Closes #3381
DaniPopes
requested review from
0xrusowsky,
figtracer,
grandizzy,
mablr,
mattsse and
stevencartavia
as code owners
July 9, 2026 19:34
mattsse
requested changes
Jul 9, 2026
mattsse
left a comment
mattsse
left a comment
Member
There was a problem hiding this comment.
Thanks, this is much cleaner overall. I found two compatibility regressions that should be addressed before merge.
crates/config/src/lib.rs: the configured checks treat the presence of any[tracing]table as iftracing.verbositywas explicitly configured. With a config like top-levelverbosity = 4plus[tracing] disable_labels = true,normalize_tracing_settingscopies the default tracing verbosity (0) back intoself.verbosity, suppressing verbose trace output.
Suggested fix: make the verbosity checks leaf-key only in both from_figment_inner and merge_inline_provider, e.g. figment_value_is_configured(&figment, "tracing.verbosity") / provider.contains("tracing.verbosity"), and add a regression test where [tracing] contains a non-verbosity option while top-level verbosity remains set.
cast run -l <addr:label>no longer parses. FlatteningTracingArgskeeps--labelsand--label, but drops the previous#[arg(long, short)]labelfield fromRunArgs.
Suggested fix: avoid adding short = 'l' to shared TracingArgs globally because forge test -l is already --list. Instead, keep a command-specific hidden #[arg(short = 'l', value_name = "ADDRESS:LABEL")] Vec on RunArgs, merge it into self.tracing.labels before resolve, and add a parse test for cast run -l ....
mablr
reviewed
Jul 9, 2026
mablr
left a comment
mablr
left a comment
Member
There was a problem hiding this comment.
I confirm Matt's findings, and have two more.
# Conflicts: # crates/cast/src/cmd/run.rs # crates/config/src/providers/warnings.rs
mablr
reviewed
Jul 10, 2026
mablr
reviewed
Jul 10, 2026
DaniPopes
enabled auto-merge (squash)
July 16, 2026 23:38
Keep canonical tracing labels available to cheatcodes while retaining direct legacy Config callers. Preserve malformed canonical values so configuration errors are not masked by the compatibility provider.
# Conflicts: # crates/forge/tests/cli/script.rs
# Conflicts: # crates/script/src/lib.rs # crates/script/src/simulate.rs
mablr
reviewed
Jul 21, 2026
Disable internal decoding for RPC call-tracer responses and emit configuration migration warnings from cast trace commands. Normalize inherited label aliases before merging to preserve source precedence and collision detection.
Normalize standalone tracing within each inherited source before coalescing so aliases and profile-qualified settings preserve local precedence and participate in collision detection.
mattsse
approved these changes
Jul 21, 2026
mablr
approved these changes
Jul 21, 2026
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates trace rendering options in shared
TracingArgsfor cast, forge, and script, with defaults under[tracing]. CLI overrides resolve into a cloned effectiveTracingConfig, which is passed through trace collection, decoder construction, and rendering. Legacy[labels]and profile-locallabelsremain supported with deprecation warnings that point to[tracing.labels]. This subsumes #15662 by including--compact-labelsin the shared trace options and threading it through decoding. Closes #3381. AI assistance was used for this change, per CONTRIBUTING.md.